Skip to content

Remove .NET Monitor 8.0#6372

Merged
lbussell merged 2 commits into
dotnet:nightlyfrom
jander-msft:remove-monitor-8.0
Apr 15, 2025
Merged

Remove .NET Monitor 8.0#6372
lbussell merged 2 commits into
dotnet:nightlyfrom
jander-msft:remove-monitor-8.0

Conversation

@jander-msft

Copy link
Copy Markdown
Contributor

.NET Monitor 8.1 superseded .NET Monitor 8.0 on February 11, 2025 as the latest .NET Monitor 8 release. As announced in dotnet/dotnet-monitor#7938, .NET Monitor 8.0 will be EOL on May 11, 2025, which is before the next planned servicing release. This change removes the Dockerfiles and related infrastructure for .NET Monitor 8.0 since the Docker images will no longer be maintained at the next planned servicing release.

@jander-msft jander-msft requested a review from a team as a code owner April 14, 2025 20:16

@lbussell lbussell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test data:

new ProductImageData { Version = V8_0, VersionFamily = V8_0, OS = OS.AzureLinux30Distroless, OSTag = OS.MarinerDistroless, Arch = Arch.Amd64, SupportedImageRepos = DotNetImageRepo.Monitor },
new ProductImageData { Version = V8_0, VersionFamily = V8_0, OS = OS.AzureLinux30Distroless, OSTag = OS.MarinerDistroless, Arch = Arch.Arm64, SupportedImageRepos = DotNetImageRepo.Monitor },

Also why isn't this failing? 😕 There might be an issue with monitor tests running:
image

@jander-msft

Copy link
Copy Markdown
Contributor Author

Remove the test data:

new ProductImageData { Version = V8_0, VersionFamily = V8_0, OS = OS.AzureLinux30Distroless, OSTag = OS.MarinerDistroless, Arch = Arch.Amd64, SupportedImageRepos = DotNetImageRepo.Monitor },
new ProductImageData { Version = V8_0, VersionFamily = V8_0, OS = OS.AzureLinux30Distroless, OSTag = OS.MarinerDistroless, Arch = Arch.Arm64, SupportedImageRepos = DotNetImageRepo.Monitor },

Also why isn't this failing? 😕 There might be an issue with monitor tests running:

I agree that the .NET Monitor test data needs to be removed (oops!), but this isn't indicative of the .NET Monitor tests not running. The tests are filtered using file paths to Dockerfiles based on the manifest. If the manifest doesn't have entries for the .NET Monitor 8.0 paths, then the .NET Monitor 8.0 image data is filtered out so they aren't run.

As for why Azure DevOps is saying they aren't executed (if you hover on the icon it has a tooltip of "Not executed"), I'm not sure. Here are the same visualizations for .NET 10 Azure Linux (which there aren't any .NET Monitor images yet):

Screenshot 2025-04-15 085938

and .NET 10 Windows Nano Server (where .NET Monitor has never had any Windows images):

Screenshot 2025-04-15 090057

So in my mind, it showing "Not executed" for some test doesn't really mean anything.

In any event, I will remove the .NET Monitor 8.0 image test data.

@lbussell

Copy link
Copy Markdown
Member

The tests are filtered using file paths to Dockerfiles based on the manifest. If the manifest doesn't have entries for the .NET Monitor 8.0 paths, then the .NET Monitor 8.0 image data is filtered out so they aren't run.

Ah, yeah, makes sense with the current setup. No concern from me then.

@lbussell lbussell merged commit 3119913 into dotnet:nightly Apr 15, 2025
lbussell pushed a commit to lbussell/dotnet-docker that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants